Upgrade YASA to work with Solr 9x, with a 0.6.0 release #95
Conversation
chatman
requested review from
epugh,
MarcusSorealheis,
kezhenxu94,
almogtavor and
a team
There was a problem hiding this comment.
From my experience this file should be checked into codebase, otherwise in a fresh new environment the installed packages' versions might be different from the ones that we tested, and it might break the build
There was a problem hiding this comment.
+1, I don't see a reason to remove it
There was a problem hiding this comment.
agreed... package-lock.json should be shared...
|
Ok sure, sorry about that one.
…On Fri, 21 Apr, 2023, 8:24 am kezhenxu94, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
On yasa-ui/package-lock.json
<#95 (comment)>:
From my experience this file should be checked into codebase, otherwise in
a fresh new environment the installed packages' versions might be different
from the ones that we tested, and it might break the build
—
Reply to this email directly, view it on GitHub
<#95 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABDCR5BFRPGBPWEWVB53QG3XCHZIDANCNFSM6AAAAAAXF3PNRE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
kezhenxu94
force-pushed
the
master
branch
3 times, most recently
from
663a13b
to
085918c
Compare
Hey @chatman , I've created a workflow to automatically release a version on new tags (yasa-org/developer members can create tags), if you need a new version, feel free to push a tag and use the new release, note the tag name should be v1.2.3 format, https://github.com/yasa-org/yasa/actions/workflows/Release.yaml |
|
We should test with version 17 as well. |
|
This works with Solr 9.0 and 9.1. It is broken with 9.2, due to https://issues.apache.org/jira/browse/SOLR-16769. |
This should stay and not be ignored...
There was a problem hiding this comment.
awesome! I literally got bit by this in writing a nicer test_packages.bats test!
Tested with Solr 9.0, works fine.
After merging this, next steps to release would be:
Steps to sign:
{{openssl dgst -sha1 -sign <path-to-privatekey.pem> | openssl enc -base64}}
(remove the newline, concatenate the first and second line to form a single string without spaces)